Fix debug console after restarting debug session #192949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sposed when a DebugSession is restarted Fix #192653
Now we don't dispose some listeners in DebugSession, this is by design
roblourens
changed the title
deepak1556
approved these changes
Sep 13, 2023
lins0621
pushed a commit
to lins0621/vscode
that referenced
this pull request
Sep 14, 2023
* Don't add global DebugSession listeners to rawListeners, which are disposed when a DebugSession is restarted Fix microsoft#192653 * Fix failing unit test Now we don't dispose some listeners in DebugSession, this is by design * Fix failing unit tests
hhc87
pushed a commit
to lins0621/vscode
that referenced
this pull request
Oct 8, 2023
* Don't add global DebugSession listeners to rawListeners, which are disposed when a DebugSession is restarted Fix microsoft#192653 * Fix failing unit test Now we don't dispose some listeners in DebugSession, this is by design * Fix failing unit tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for #192653 in main
This looks weird but it is just restoring the leaky code that we've had for a long time. Got #191904 for the larger issue