Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add the logo of the built-in extension #192999

Merged
merged 4 commits into from
Oct 5, 2023

Conversation

yiliang114
Copy link
Contributor

before:
image

@sandy081 sandy081 assigned rebornix and alexr00 and unassigned sandy081 Sep 14, 2023
@alexr00 alexr00 removed their assignment Sep 14, 2023
@rebornix rebornix assigned sandy081 and rebornix and unassigned rebornix and sandy081 Sep 15, 2023
@rebornix
Copy link
Member

@daviddossett do we have guidance on adding builtin extension icons?

@daviddossett
Copy link
Contributor

@daviddossett do we have guidance on adding builtin extension icons?

@rebornix nothing specific that I know of but I added some comments re: the image formats.

@VSCodeTriageBot VSCodeTriageBot added this to the September 2023 milestone Sep 19, 2023
@rebornix rebornix modified the milestones: September 2023, October 2023 Sep 28, 2023
@rebornix rebornix merged commit f6790fc into microsoft:main Oct 5, 2023
6 checks passed
Alex0007 pushed a commit to Alex0007/vscode that referenced this pull request Oct 26, 2023
* feat: Add the logo of the built-in extension

* chore(extension): add compressed icon

---------

Co-authored-by: Martin Aeschlimann <martinae@microsoft.com>
@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants