Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

option to scroll to the top of the next cell #193126

Merged
merged 10 commits into from
Sep 15, 2023
Merged

Conversation

amunger
Copy link
Contributor

@amunger amunger commented Sep 14, 2023

for #191086

new options for scrolling behavior:

  • Scroll to fully reveal the next cell. (current behavior, and using as default for now)
  • Scroll to reveal the first line of the next cell. (requested in the linked issue)
  • Do not scroll at all. (requested in this comment)

After people have been able to experiment, I imagine we will change the default to the second option.

@amunger amunger marked this pull request as ready for review September 15, 2023 18:27
@VSCodeTriageBot VSCodeTriageBot added this to the September 2023 milestone Sep 15, 2023
Copy link
Member

@rebornix rebornix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use viewContext.notebookOptions.getLayoutConfiguration() for calculating the padding instead of constants.

rebornix
rebornix previously approved these changes Sep 15, 2023
@amunger amunger merged commit 7bdc382 into main Sep 15, 2023
6 checks passed
@amunger amunger deleted the aamunger/scrollOnExecute branch September 15, 2023 22:51
@NickCrews
Copy link

Thank you @amunger, I just got this feature in the newest version and the "do not scroll" option is finally what I have been looking for! 🙏

@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants