voice - cleanup disposables #193199
Merged
voice - cleanup disposables #193199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
approved these changes
Sep 15, 2023
Comment on lines
+147
to
152
| override dispose(): void { | ||
| super.dispose(); | ||
|
|
||
| this.data = new Float32Array(0); | ||
| } | ||
| } |
There was a problem hiding this comment.
nit: overriding dispose is a little dangerous as it's not enforced that super.dispose() is called. Can you do this instead in the ctor?
this._register(toDisposable(() => this.data = new Float32Array(0)));
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.