Sort settings by ToC when ToC shown #193242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I plan on merging #193635 first, which will reduce the number of less relevant search results. |
|
Hm, I don't like the results |
|
This PR is ready to merge after #193635 is merged |
rzhao271
force-pushed
the
rzhao271/filter-settings
branch
from
bef1e29
to
2209c10
Compare
roblourens
approved these changes
Sep 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #187959
This PR changes the Settings editor search behaviour as follows:
filter, then the ToC (table of contents) is shown during search, and we sort the settings by their order in the ToChide, then the ToC is not shown during search, and we sort the settings the old way, disregarding the settings order, but placing exact keyword matches up front