Allow cmd+c to copy chat row content #193410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joyceerhl
reviewed
Sep 18, 2023
| @@ -351,6 +354,7 @@ export class ChatWidget extends Disposable implements IChatWidget { | |||
| })); | |||
| this._register(this.tree.onDidFocus(() => { | |||
| this._onDidFocus.fire(); | |||
| this.chatListFocused.set(this.tree.isDOMFocused()); | |||
There was a problem hiding this comment.
Does this need to be updated when this.tree.onDidBlur fires?
There was a problem hiding this comment.
technically it's fine, but it looks like it should, so I'll just add it
joyceerhl
approved these changes
Sep 18, 2023
roblourens
added a commit
that referenced
this pull request
Sep 26, 2023
This reverts commit ee8f89f.
roblourens
added a commit
that referenced
this pull request
Sep 26, 2023
lins0621
pushed a commit
to lins0621/vscode
that referenced
this pull request
Oct 7, 2023
…rosoft#194076) This reverts commit ee8f89f.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix microsoft/vscode-copilot#1433