Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add disposableTimeout calls to disposable stores #193673

Merged
merged 5 commits into from
Sep 21, 2023
Merged

add disposableTimeout calls to disposable stores #193673

merged 5 commits into from
Sep 21, 2023

Conversation

joaomoreno
Copy link
Member

@joaomoreno joaomoreno commented Sep 21, 2023 •
edited

Related to #193613

@joaomoreno joaomoreno enabled auto-merge (squash) September 21, 2023 13:06
@joaomoreno joaomoreno self-assigned this Sep 21, 2023
@joaomoreno joaomoreno changed the title fix compile error add disposableTimeout calls to disposable stores Sep 21, 2023
@VSCodeTriageBot VSCodeTriageBot added this to the September 2023 milestone Sep 21, 2023
@Tyriar
Copy link
Member

Tyriar commented Sep 21, 2023

Just merging won't fix it, you need to revert the changes to terminalTabsList.ts in this PR and I think the this.disposables.add(dnd); part in https://github.com/microsoft/vscode/pull/193666/files

@joaomoreno joaomoreno merged commit 4039416 into main Sep 21, 2023
6 checks passed
@joaomoreno joaomoreno deleted the joao/crimson-chipmunk branch September 21, 2023 18:36
@joaomoreno
Copy link
Member Author

Thanks!

@github-actions github-actions bot locked and limited conversation to collaborators Nov 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

@joaomoreno joaomoreno

Labels
None yet
Projects
None yet
Milestone
September 2023
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@joaomoreno @Tyriar @VSCodeTriageBot