Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct the CLI helptext for --profile #193766

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Correct the CLI helptext for --profile #193766

merged 2 commits into from
Oct 5, 2023

Conversation

gjsjohnmurray
Copy link
Contributor

@gjsjohnmurray gjsjohnmurray commented Sep 22, 2023 •
edited

The text from code --help states:

  --profile <profileName>                    Opens the provided folder or
                                             workspace with the given profile
                                             and associates the profile with
                                             the workspace. If the profile
                                             does not exist, a new empty one
                                             is created. A folder or workspace
                                             must be provided for the profile
                                             to take effect.

But the final sentence doesn't seem to be true. When I launch like this VS Code is using the profile I specified and no folder or workspace is open 馃憤

PS C:\Users\JohnM> code-insiders --profile "InterSystems"

@gjsjohnmurray
Copy link
Contributor Author

/assign @sandy081

@sandy081 sandy081 added this to the October 2023 milestone Sep 26, 2023
@sandy081 sandy081 self-requested a review September 26, 2023 15:01
@sandy081 sandy081 merged commit 4aac894 into microsoft:main Oct 5, 2023
6 checks passed
@gjsjohnmurray gjsjohnmurray deleted the maroon-squid branch October 5, 2023 12:23
Alex0007 pushed a commit to Alex0007/vscode that referenced this pull request Oct 26, 2023
@sandy081 @Alex0007
Merge pull request microsoft#193766 from gjsjohnmurray/maroon-squid
273e40c 
Correct the CLI helptext for `--profile`
@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sandy081 sandy081 sandy081 approved these changes

@alexr00 alexr00 alexr00 approved these changes

Assignees

@sandy081 sandy081

Labels
None yet
Projects
None yet
Milestone
October 2023
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gjsjohnmurray @sandy081 @alexr00