Context Menu Enables Pinned Tabs On Seperate Row #193813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpasero
requested changes
Sep 22, 2023
bpasero
requested changes
Sep 25, 2023
src/vs/workbench/browser/parts/editor/multiEditorTabsControl.ts
Outdated
Show resolved
Hide resolved
bpasero
requested changes
Sep 25, 2023
bpasero
approved these changes
Sep 25, 2023
lins0621
pushed a commit
to lins0621/vscode
that referenced
this pull request
Oct 7, 2023
* Context menu seperate pinned tabs * unpinned instead of notpinned * 💄 * Base class toggle setting action * compute context before open menu * default false * 💄 * 💄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#193689
If the active editor group has at leat one pinned and one unpinned tab, create context menu to toggle the
workbench.editor.pinnedTabsOnSeparateRowsettingOnly checking active group for this state and not all groups as I think it leads to the best experience.