setting to anchor to focused cell #193833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amunger
commented
Sep 22, 2023
| @@ -528,7 +528,7 @@ export class ListView<T> implements IListView<T> { | |||
| // do not scroll the viewport if resized element is out of viewport | |||
| heightDiff = size - originalSize; | |||
| } else { | |||
| if (anchorIndex !== null && anchorIndex > index && anchorIndex <= lastRenderRange.end) { | |||
There was a problem hiding this comment.
this was a bug, the lastRenderRange.end is the index after the final visible index as documented in the indexAfter function, used by getRenderRange
Yoyokrazy
reviewed
Sep 22, 2023
src/vs/workbench/contrib/notebook/browser/notebook.contribution.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/notebook/browser/view/notebookCellList.ts
Outdated
Show resolved
Hide resolved
Yoyokrazy
reviewed
Sep 22, 2023
Yoyokrazy
approved these changes
Sep 22, 2023
|
Unsure if this broke scrolling further, please read #193231 (comment) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #169038
fixes #193231
previously (in stable currently), the focused cell would be anchored only if the cell changing size was partially visible as shown in #193231. This will set the focused cell as anchored consistently by default, with a setting to disable that behavior.
Also changes the reveal full cell behavior back to revealing in the center, rather than pinning it to the bottom, which ended up focusing on the next cells output.