Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert default behavior back to previous #194037

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Conversation

amunger
Copy link
Contributor

@amunger amunger commented Sep 25, 2023

adjusting for feedback on #193231 (comment)

  • Go back to minimal scrolling to reveal the full next cell since it behaves better for the more common case.
  • The default "auto" anchorFocusedElement setting will now behave as it did previously: focused the anchored cell if the one resizing is only partially visible

Copy link
Member

@rebornix rebornix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in OSS, works as expected.

@amunger amunger enabled auto-merge (rebase) September 25, 2023 20:49
@amunger amunger merged commit 8a9f1f2 into main Sep 25, 2023
7 checks passed
@amunger amunger deleted the aamunger/notebookScrollTweaks branch September 25, 2023 20:49
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants