Enable logging only for ext test telemetry #194056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeschli
approved these changes
Sep 25, 2023
lins0621
pushed a commit
to lins0621/vscode
that referenced
this pull request
Oct 7, 2023
Attempt to enable logging only for ext test telemetry
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running an extension test we will log telemetry to allow for debugging but not send it. This is done by extending our logging only support. Can test via
./scripts/code.sh --extensionTestsPath fooone major caveat is multiple windows of VS Code from the same executable will inherit whatever the initial launched window has (i.e. if it was running a test or not) due to shared processes being shared across windows. There's no easy way aroudn this, but this should unblock most testing cases since they use their own VS Code executable pulled down from the vscode test electron package.