Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing completions for code action kinds #194121

Closed
jrieken opened this issue Sep 26, 2023 · 1 comment
Closed

Missing completions for code action kinds #194121

jrieken opened this issue Sep 26, 2023 · 1 comment
Assignees
@Yoyokrazy

Comments

@jrieken
Copy link
Member

jrieken commented Sep 26, 2023 •
edited
Loading

Testing #194077

I am missing completions for code action kinds when authoring the notebook.codeActionsOnSave setting. As soon as a provider is register we do know its kinds and we can update the JSON schema accordingly. This will greatly improve the configuration experience because today configuration is manual/magic. You need to rely on well known or documented code action kinds and copy-paste them

Steps

  • use lastest GHINB from joh/civic-tahr
  • open a GHI notebook
  • configure notebook code actions for saving
@mjbvz
Copy link
Collaborator

mjbvz commented Sep 27, 2023

Duplicate of #161284

@mjbvz mjbvz marked this as a duplicate of #161284 Sep 27, 2023
@mjbvz mjbvz closed this as completed Sep 27, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Yoyokrazy Yoyokrazy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jrieken @Yoyokrazy @mjbvz