Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add confirm for protocol links but allow to opt-out #194405

Merged
merged 5 commits into from
Oct 2, 2023
Merged

Add confirm for protocol links but allow to opt-out #194405

merged 5 commits into from
Oct 2, 2023

Conversation

bpasero
Copy link
Member

@bpasero bpasero commented Sep 28, 2023 •
edited

fixes #95670

@bpasero bpasero self-assigned this Sep 28, 2023
@bpasero bpasero changed the title wip Add confirm for protocol links but allow to opt-out Sep 28, 2023
@bpasero bpasero marked this pull request as ready for review September 29, 2023 06:08
@bpasero bpasero added this to the October 2023 milestone Sep 29, 2023
aeschli
aeschli previously approved these changes Sep 29, 2023
View reviewed changes
This was referenced Sep 29, 2023
Closed
Closed
@bpasero bpasero enabled auto-merge (squash) October 2, 2023 14:06
@bpasero bpasero merged commit 8f38222 into main Oct 2, 2023
6 checks passed
@bpasero bpasero deleted the ben/protocol-confirm branch October 2, 2023 14:20
@hrgdavor
Copy link

hrgdavor commented Oct 8, 2023

when will this go live ? I just recently started to use open in vscode for web dev, and opt-out for the prompt will be veeeeery nice.

@bpasero
Copy link
Member Author

bpasero commented Oct 8, 2023

Can you try to reproduce with our nightly insider builds? You can give our preview releases a try from: https://code.visualstudio.com/insiders/

@dantswain
Copy link

After updating insiders I am now getting this dialog every time I cmd+click to open a file from Warp terminal. It doesn't seem to matter whether or not I click the checkbox.

Before the update I wasn't getting the dialog at all, cmd+click was working exactly as expected.

Happy to report this somewhere else if there's a better spot.

Version: 1.84.0-insider (Universal)
Commit: 874831ebcf088f59735879156f62308ce48f17d1
Date: 2023-10-06T19:18:47.163Z
Electron: 25.8.4
ElectronBuildId: 24154031
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: 11.4.183.29-electron.0
OS: Darwin arm64 23.0.0

@bpasero
Copy link
Member Author

bpasero commented Oct 9, 2023

That should not happen so please report a new issue.

@dantswain dantswain mentioned this pull request Oct 11, 2023
Closed
Alex0007 pushed a commit to Alex0007/vscode that referenced this pull request Oct 26, 2023
@bpasero @Alex0007
Add confirm for protocol links but allow to opt-out (microsoft#194405)
cf87c93 
* wip

* simplify

* 💄
@github-actions github-actions bot locked and limited conversation to collaborators Nov 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aeschli aeschli aeschli approved these changes

@sandy081 sandy081 sandy081 approved these changes

Assignees

@bpasero bpasero

Labels
None yet
Projects
None yet
Milestone
October 2023
Development

Successfully merging this pull request may close these issues.

Allow to opt-out of URL protocol confirmation dialog
5 participants
@bpasero @hrgdavor @dantswain @aeschli @sandy081