Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed default settings for Code Actions on Save #194409

Merged
merged 8 commits into from
Sep 28, 2023

Conversation

justschen
Copy link
Contributor

@justschen justschen commented Sep 28, 2023

fixes #194397, #194394

commented out potential fix for #194375

@justschen justschen changed the title Removed default settings for Code Actions on Save [WIP] Removed default settings for Code Actions on Save Sep 28, 2023
@justschen justschen marked this pull request as draft September 28, 2023 18:25
@justschen justschen requested review from rebornix and removed request for Yoyokrazy September 28, 2023 18:25
@justschen justschen marked this pull request as ready for review September 28, 2023 20:58
@justschen justschen changed the title [WIP] Removed default settings for Code Actions on Save Removed default settings for Code Actions on Save Sep 28, 2023
@justschen justschen enabled auto-merge (squash) September 28, 2023 21:13
@justschen justschen merged commit 411d298 into microsoft:main Sep 28, 2023
6 checks passed
@bhavyaus bhavyaus added the unreleased Patch has not yet been released in VS Code Insiders label Sep 28, 2023
@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Sep 29, 2023
Alex0007 pushed a commit to Alex0007/vscode that referenced this pull request Oct 26, 2023
* removed default settings

* removed whitespace

* changed wordage

* boolean and string enum together

* updated language around settings, mentioning things will be deprecated

* changed settings accross noteboks as well

* Update codeActionModel.ts
@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[regression] CodeAction on save is broken
4 participants