Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix notebook insertFinalNewline behavior #194442

Merged
merged 2 commits into from
Sep 28, 2023
Merged

Fix notebook insertFinalNewline behavior #194442

merged 2 commits into from
Sep 28, 2023

Conversation

Yoyokrazy
Copy link
Contributor

fixes #194175

@Yoyokrazy Yoyokrazy enabled auto-merge (squash) September 28, 2023 22:00
@VSCodeTriageBot VSCodeTriageBot added this to the September 2023 milestone Sep 28, 2023
justschen
justschen approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@justschen justschen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Yoyokrazy Yoyokrazy merged commit 00651c4 into main Sep 28, 2023
6 checks passed
@Yoyokrazy Yoyokrazy deleted the shaky-carp branch September 28, 2023 22:43
Alex0007 pushed a commit to Alex0007/vscode that referenced this pull request Oct 26, 2023
@Yoyokrazy @Alex0007
Fix notebook insertFinalNewline behavior (microsoft#194442)
d21a1b8 
fix typing newline bug
@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rebornix rebornix rebornix approved these changes

@justschen justschen justschen approved these changes

Assignees

@Yoyokrazy Yoyokrazy

Labels
None yet
Projects
None yet
Milestone
September 2023
Development

Successfully merging this pull request may close these issues.

insertFinalNewline breaks typings in first line in a new cell
4 participants
@Yoyokrazy @rebornix @justschen @VSCodeTriageBot