Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More notebook scroll on execute polish #194516

Closed
amunger opened this issue Sep 29, 2023 · 3 comments · Fixed by #195309
Closed

More notebook scroll on execute polish #194516

amunger opened this issue Sep 29, 2023 · 3 comments · Fixed by #195309
Assignees
Labels
insiders-released Patch has been released in VS Code Insiders notebook-output on-testplan polish Cleanup and polish issue
Milestone

Comments

@amunger
Copy link
Contributor

amunger commented Sep 29, 2023

Ideas to experiment with:

  • Don't shrink a cell while it is executing -> less jumpy as output is replaced
  • change the anchor heuristic from "if the resizing cell is partially visible" to "if the cell's output will shrink out of view"
  • Anchor to a focused cell if the focus is in the cell's editor

cc @rebornix

@rebornix
Copy link
Member

For the new heuristics we are adding (growing upwards or downwards), they should probably be interrupted the moment users start to scroll, for example, if I scroll manually to a specific position, I would expect the scroll top not to change.

@amunger
Copy link
Contributor Author

amunger commented Oct 10, 2023

I disagree - That could mean if you have a cell focused and anchored, and you scroll to get it higher in the view, it would then start getting pushed down as the previous cell grows.

@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Oct 10, 2023
@rebornix
Copy link
Member

rebornix commented Oct 11, 2023

you scroll to get it higher in the view, it would then start getting pushed down as the previous cell grows

If I scroll to get it lower in the view, as I want to read the cells above, and since it's still in the view and focused/anchored, the cells I was reading will then pushed upwards, right?

Screen.Recording.2023-10-10.at.8.53.01.PM.mov

This feels unnatural compared to how browser handles scrolling or Terminal. Terminal scenario might be closer to this, as it usually sticks to the bottom when the shell is streaming outputs, but the very moment we scroll upwards, it stops sticking to the bottom.

@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Oct 11, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
insiders-released Patch has been released in VS Code Insiders notebook-output on-testplan polish Cleanup and polish issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants