Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch Remote button not working after hiding #194604

Merged
merged 4 commits into from Oct 4, 2023
Merged

Conversation

alexr00
Copy link
Member

@alexr00 alexr00 commented Oct 2, 2023

Fixes #194569
Part of #194603

@alexr00 alexr00 requested a review from sandy081 October 2, 2023 12:08
@alexr00 alexr00 self-assigned this Oct 2, 2023
@alexr00 alexr00 enabled auto-merge (squash) October 2, 2023 12:08
@VSCodeTriageBot VSCodeTriageBot added this to the October 2023 milestone Oct 2, 2023
@sandy081
Copy link
Member

sandy081 commented Oct 2, 2023

@alexr00 Looks like the new changes are not considering the remote views contributed by an extension when it is installed. In the below screenshot, I just installed dev containers extensions and the dropdown is not updated

image

@alexr00 alexr00 requested a review from sandy081 October 3, 2023 09:59
Copy link
Member Author

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sandy081, thank you for the help! This is now ready to review again.

@sandy081
Copy link
Member

sandy081 commented Oct 4, 2023

LGTM. Thanks for the changes 👏

@alexr00 alexr00 merged commit 4f7a76b into main Oct 4, 2023
6 checks passed
@alexr00 alexr00 deleted the alexr00/issue194569 branch October 4, 2023 07:36
Alex0007 pushed a commit to Alex0007/vscode that referenced this pull request Oct 26, 2023
* Switch Remote button not working after hiding
Fixes microsoft#194569
Part of microsoft#194603

* Respond to PR feedback

* Fix for uninstalled extensions and for extensions that don't activate

* Fix active remote view not being selected
@github-actions github-actions bot locked and limited conversation to collaborators Nov 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remote explorer - Switch Remote button not working
3 participants