Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add update-desktop-database calls #194645

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Conversation

rzhao271
Copy link
Contributor

@rzhao271 rzhao271 commented Oct 2, 2023

Fixes #193951

@rzhao271 rzhao271 self-assigned this Oct 2, 2023
@rzhao271 rzhao271 enabled auto-merge (squash) October 2, 2023 18:42
@rzhao271 rzhao271 added this to the October 2023 milestone Oct 2, 2023
@deepak1556
Copy link
Contributor

deepak1556 commented Oct 3, 2023

Changes look good, please verify the following scenarios before merging:

  • Install rpm created from this PR on CentOS 7 and verify url handler flow works
  • Update the installed package to latest published rpm and verify url handler flow continues to work
  • Install deb package from this PR on debian distro and update to latest published version, verify url handler flow works after the update

@rzhao271
Copy link
Contributor Author

rzhao271 commented Oct 3, 2023

The update scripts currently no-op because the custom Insiders build is newer than the latest published Insiders.
I'll wait until later to test the remaining items.

@rzhao271
Copy link
Contributor Author

rzhao271 commented Oct 4, 2023

Verified on CentOS 7 the following way:

  1. I installed Insiders build 2f2b9e8 which is based off of this branch
  2. I ran gio open vscode-insiders://. and verified that code-insiders loaded.
  3. I updated code-insiders to 4a0e776 using yum by following the official instructions.
  4. I ran gio open vscode-insiders://. and verified that code-insiders loaded.

@rzhao271
Copy link
Contributor Author

rzhao271 commented Oct 4, 2023

Verified on Ubuntu 22.04 the following way:

  1. I installed Insiders build 0f4f31c which is based off of this branch. It's older than the build I used to verify the rpm package, but the most recent change only affects the rpm package post-install scripts, so it's fine.
  2. I ran xdg-open vscode-insiders://. and verified that code-insiders loaded.
  3. I updated code-insiders to 4a0e776 using apt-get.
  4. I ran xdg-open vscode-insiders://. and verified that code-insiders loaded.

@rzhao271 rzhao271 merged commit 4aaab19 into main Oct 5, 2023
15 checks passed
@rzhao271 rzhao271 deleted the rzhao271/influential-tarantula branch October 5, 2023 08:52
Alex0007 pushed a commit to Alex0007/vscode that referenced this pull request Oct 26, 2023
* Add update-desktop-database calls

* Fix symbol
@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rpm doesn't run update-desktop-database
2 participants