Add support to edit all potential Quick Fixes in the line #194660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connor4312
approved these changes
Oct 2, 2023
| @@ -37,10 +37,10 @@ Registry.as<IConfigurationRegistry>(Extensions.Configuration).registerConfigurat | |||
| Registry.as<IConfigurationRegistry>(Extensions.Configuration).registerConfiguration({ | |||
| ...editorConfigurationBaseNode, | |||
| properties: { | |||
| 'editor.codeActionWidget.includeNearbyQuickfixes': { | |||
| 'editor.codeActionWidget.includeNearbyQuickFixes': { | |||
There was a problem hiding this comment.
When a setting"s name changes, even only a case-change, shouldn't I also see changes in code that references the setting value, plus migration code to update a user's settings?
There was a problem hiding this comment.
Completely went over my head - great catch! The fixes/feature changes worked as intended since this bit of code hadn't been change, so I didn't think to update that.
Alex0007
pushed a commit
to Alex0007/vscode
that referenced
this pull request
Oct 26, 2023
…194660) * fixes naming schema and added support to show all quickfixes * code cleanup
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #194222 and small update to #194636