Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alert on terminal / chat clear #194666

Merged
merged 2 commits into from
Oct 2, 2023
Merged

alert on terminal / chat clear #194666

merged 2 commits into from
Oct 2, 2023

Conversation

meganrogge
Copy link
Contributor

@meganrogge meganrogge commented Oct 2, 2023 •
edited

fixes #185155

@meganrogge meganrogge requested a review from Tyriar October 2, 2023 22:15
@meganrogge meganrogge self-assigned this Oct 2, 2023
@meganrogge meganrogge added this to the October 2023 milestone Oct 2, 2023
@meganrogge meganrogge changed the title alert on terminal clear alert on terminal / chat clear Oct 2, 2023
roblourens
roblourens approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@roblourens roblourens left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

debug console? output channel? search results? Just thinking of other things that get cleared

@meganrogge meganrogge merged commit f686e32 into main Oct 2, 2023
6 checks passed
@meganrogge meganrogge deleted the merogge/cleared branch October 2, 2023 22:47
@meganrogge
Copy link
Contributor Author

meganrogge commented Oct 2, 2023 •
edited

Good points, I had assumed all of those worked fine already because JooYoung didn't mention them. I'll check though.

@meganrogge
Copy link
Contributor Author

Yep, it already works for those - not the output channel though. They're a little verbose IMO, i'll ask JooYoung what he thinks.

@meganrogge
Copy link
Contributor Author

#194672

Alex0007 pushed a commit to Alex0007/vscode that referenced this pull request Oct 26, 2023
@meganrogge @Alex0007
Merge pull request microsoft#194666 from microsoft/merogge/cleared
5247848 
`alert` on terminal / chat clear
@github-actions github-actions bot locked and limited conversation to collaborators Nov 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@roblourens roblourens roblourens approved these changes

@Tyriar Tyriar Awaiting requested review from Tyriar

Assignees

@meganrogge meganrogge

Labels
None yet
Projects
None yet
Milestone
October 2023
Development

Successfully merging this pull request may close these issues.

Alert screen reader users that something has occurred when clear is used
2 participants
@meganrogge @roblourens