Fix the rest of the node version references #194677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzhao271
approved these changes
Oct 2, 2023
joaomoreno
pushed a commit
that referenced
this pull request
Oct 10, 2023
joaomoreno
added a commit
that referenced
this pull request
Oct 10, 2023
* Try with node 18.17 (#194663) * Try with node 18.17 * And change product compile * Use 18.15, same as the local version * Fix the rest of the node version references (#194677) * Test using nvmrc in CI (#194836) * Test using nvmrc in CI * Force run yarn * fix * Bump nvmrc to latest * Revert "Force run yarn" This reverts commit af741f3. * Make all jobs use node from nvmrc And install node-gyp where needed --------- Co-authored-by: Rob Lourens <roblourens@gmail.com>
bpasero
pushed a commit
that referenced
this pull request
Oct 13, 2023
bpasero
pushed a commit
that referenced
this pull request
Oct 13, 2023
bpasero
pushed a commit
that referenced
this pull request
Oct 13, 2023
bpasero
pushed a commit
that referenced
this pull request
Oct 14, 2023
bpasero
pushed a commit
that referenced
this pull request
Oct 14, 2023
Alex0007
pushed a commit
to Alex0007/vscode
that referenced
this pull request
Oct 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #194665