Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCM - Source Control Repositories view to use scm.providerCountBadge #194696

Merged
merged 4 commits into from
Oct 18, 2023

Conversation

lszomoru
Copy link
Member

@lszomoru lszomoru commented Oct 3, 2023

No description provided.

@lszomoru lszomoru self-assigned this Oct 3, 2023
@lszomoru lszomoru added this to the October 2023 milestone Oct 3, 2023
@lszomoru lszomoru added the scm General SCM compound issues label Oct 3, 2023
@lszomoru lszomoru requested review from joaomoreno and removed request for joaomoreno October 3, 2023 09:30
@lszomoru lszomoru marked this pull request as ready for review October 3, 2023 18:30
@bilogic
Copy link

bilogic commented Oct 4, 2023

@lszomoru

Does this mean that repos with 0 changes will no longer have a badge if I set this to auto?

@lszomoru
Copy link
Member Author

lszomoru commented Oct 4, 2023

@bilogic, that is correct. I have found out that we already have a setting and established behaviour that is driven by this setting in the "Source Control" view. Since the "renderer" that renders that repository header is the same in both views ("Source Control" and "Source Control Repositories") it felt natural to adopt this setting.

@bilogic
Copy link

bilogic commented Oct 4, 2023

@lszomoru thanks, that sounds similar to -, in that we do just enough to deal with the main issue and nothing more lest it creates other problems. If we can quickly move this to production, I can give real world feedback. Thank you!

@lszomoru
Copy link
Member Author

@bilogic, thanks for the continued feedback. The problem that we are trying to address in this PR is to make it easy to differentiate between repositories that have no changes vs. the ones that do. As we already have prior art to hiding the count badge when its value is 0 it makes sense to adopt that in favour of creating new UX (ex: showing a badge with - or .). I will get this out to Insiders this week so that we get additional feedback.

@lszomoru lszomoru requested a review from Tyriar October 18, 2023 10:44
@lszomoru lszomoru enabled auto-merge (squash) October 18, 2023 10:44
jrieken
jrieken previously approved these changes Oct 18, 2023
Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
@lszomoru lszomoru merged commit fa0a303 into main Oct 18, 2023
6 checks passed
@lszomoru lszomoru deleted the lszomoru/amazing-mule branch October 18, 2023 13:44
Alex0007 pushed a commit to Alex0007/vscode that referenced this pull request Oct 26, 2023
…icrosoft#194696)

* SCM - Source Control Repositories view to use scm.providerCountBadge

* Update setting description

* Pull request feedback
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scm General SCM compound issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants