Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't change the size of internal list elements #194772

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

roblourens
Copy link
Member

@roblourens roblourens commented Oct 4, 2023

FYI @joyceerhl, these elements are owned by the list so we shouldn't style them. Also this could cause layout issues with the list because it's not expecting to have some extra size.

@roblourens roblourens enabled auto-merge (squash) October 4, 2023 03:59
@VSCodeTriageBot VSCodeTriageBot added this to the October 2023 milestone Oct 4, 2023
Copy link
Contributor

@joyceerhl joyceerhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@roblourens roblourens merged commit 7a4623d into main Oct 4, 2023
7 checks passed
@roblourens roblourens deleted the roblou/tropical-falcon branch October 4, 2023 15:55
Alex0007 pushed a commit to Alex0007/vscode that referenced this pull request Oct 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants