Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated inferred JS/TS project config #194847

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Conversation

mjbvz
Copy link
Contributor

@mjbvz mjbvz commented Oct 4, 2023

  • Switch to target es2022 by default
  • Also switch default module resolution to bundler if using more recent TS versions

/cc @andrewbranch

- Switch to target es2022 by default
- Also switch default module resolution to `bundler` if using more recent TS versions
@mjbvz mjbvz self-assigned this Oct 4, 2023
@mjbvz mjbvz enabled auto-merge (squash) October 4, 2023 23:13
@VSCodeTriageBot VSCodeTriageBot added this to the October 2023 milestone Oct 4, 2023
@andrewbranch
Copy link
Member

Should we also enable allowImportingTsExtensions? I didn’t hear pushback when I asked in the meeting. @DanielRosenwasser what do you think?

@mjbvz
Copy link
Contributor Author

mjbvz commented Oct 5, 2023

@andrewbranch I add allowImportingTsExtensions as well if the user is on TS 5.0+

@mjbvz mjbvz merged commit 6ebac17 into microsoft:main Oct 5, 2023
6 checks passed
@andrewbranch
Copy link
Member

Oh, I totally missed that. Exciting!

Alex0007 pushed a commit to Alex0007/vscode that referenced this pull request Oct 26, 2023
- Switch to target es2022 by default
- Also switch default module resolution to `bundler` if using more recent TS versions
@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants