Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Allows Arrays in Setting for Code Actions on Save #194930

Merged
merged 7 commits into from
Oct 10, 2023

Conversation

justschen
Copy link
Contributor

Fixes #194861

Insiders PR: #194870

@justschen justschen added the candidate Issue identified as probable candidate for fixing in the next release label Oct 5, 2023
@justschen justschen self-assigned this Oct 5, 2023
@justschen justschen changed the title Allows Arrays in Setting for Code Actions on Save Fix: Allows Arrays in Setting for Code Actions on Save Oct 5, 2023
@bhavyaus bhavyaus added this to the September 2023 Recovery 1 milestone Oct 5, 2023
Copy link
Member

@rebornix rebornix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm currently seeing a behavior change for suggestion with this change

@justschen
Copy link
Contributor Author

updated to match #194870 (comment)

rebornix
rebornix previously approved these changes Oct 5, 2023
@justschen justschen marked this pull request as ready for review October 10, 2023 16:20
@justschen justschen merged commit f1b07bd into release/1.83 Oct 10, 2023
6 checks passed
@justschen justschen deleted the justin/actions-candidate branch October 10, 2023 23:05
@@ -281,7 +281,7 @@ class CodeActionOnSaveParticipant implements ITextFileSaveParticipant {
const settingsOverrides = { overrideIdentifier: textEditorModel.getLanguageId(), resource: textEditorModel.uri };

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I am warning and we will see

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything will be known

@github-actions github-actions bot locked and limited conversation to collaborators Nov 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
candidate Issue identified as probable candidate for fixing in the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants