Cleanup dependencies #195026
Merged
Cleanup dependencies #195026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roblourens
previously approved these changes
Oct 6, 2023
connor4312
reviewed
Oct 6, 2023
| @@ -90,6 +90,7 @@ | |||
| "native-watchdog": "^1.4.1", | |||
| "node-pty": "1.1.0-beta5", | |||
| "tas-client-umd": "0.1.8", | |||
| "util": "^0.12.4", | |||
There was a problem hiding this comment.
We can probably kill util too, it's used in exactly on place in the browser unit tests to promisify tree-kill
There was a problem hiding this comment.
I believe it's used for webpack to compile extensions for browser targets. @aeschli please confirm.
connor4312
reviewed
Oct 6, 2023
connor4312
previously approved these changes
Oct 6, 2023
connor4312
reviewed
Oct 6, 2023
rzhao271
reviewed
Oct 6, 2023
resources/darwin/Credits.rtf
Outdated
| @@ -0,0 +1,11 @@ | |||
| {\rtf1\ansi\ansicpg1252\cocoartf1348\cocoasubrtf170 | |||
There was a problem hiding this comment.
I think that's just what rtf files look like under the hood
There was a problem hiding this comment.
No, not intentional! Thanks!
|
@connor4312 Let's merge this in and then remove more stuff, please help me out 😄 |
DonJayamanne
approved these changes
Oct 9, 2023
Alex0007
pushed a commit
to Alex0007/vscode
that referenced
this pull request
Oct 26, 2023
* move build dependencies to devDependencies * build: bump tree-sitter * dependencies cleanup * remove leftover file
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.