Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow Text Editor to show up in focusedView #195181

Merged
merged 14 commits into from
Oct 12, 2023
Merged

allow Text Editor to show up in focusedView #195181

merged 14 commits into from
Oct 12, 2023

Conversation

meganrogge
Copy link
Contributor

fix #192534

@meganrogge meganrogge self-assigned this Oct 9, 2023
@meganrogge meganrogge added this to the October 2023 milestone Oct 9, 2023
@meganrogge meganrogge changed the title allow Editor to show up in focusedView allow Text Editor to show up in focusedView Oct 9, 2023
bpasero
bpasero previously requested changes Oct 10, 2023
View reviewed changes
src/vs/workbench/browser/parts/titlebar/windowTitle.ts Outdated Show resolved Hide resolved
src/vs/workbench/browser/parts/titlebar/windowTitle.ts Outdated Show resolved Hide resolved
@bpasero bpasero disabled auto-merge October 12, 2023 05:30
@bpasero bpasero enabled auto-merge (squash) October 12, 2023 05:31
@bpasero
Copy link
Member

bpasero commented Oct 12, 2023

@meganrogge fyi for PRs I prefer "Auto-merge and squash" so that the commits history is squashed into a single commit, especialy when the commits are small and not worthy to be preserved. The PR extension also offers it

image

@bpasero bpasero merged commit 0719762 into main Oct 12, 2023
6 checks passed
@bpasero bpasero deleted the merogge/editor-window-title branch October 12, 2023 06:58
@pokey
Copy link
Contributor

pokey commented Oct 13, 2023

you're an accessibility superhero @meganrogge, thanks for your work! 🦸

Alex0007 pushed a commit to Alex0007/vscode that referenced this pull request Oct 26, 2023
@meganrogge @Alex0007
allow Text Editor to show up in focusedView (microsoft#195181)
65fdaa7
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bpasero bpasero bpasero approved these changes

@chrmarti chrmarti chrmarti approved these changes

Assignees

@meganrogge meganrogge

Labels
None yet
Projects
None yet
Milestone
October 2023
Development

Successfully merging this pull request may close these issues.

Focused view missing for text editor
4 participants
@meganrogge @bpasero @pokey @chrmarti