Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify pipeline actions #195197

Merged
merged 2 commits into from
Oct 11, 2023
Merged

Clarify pipeline actions #195197

merged 2 commits into from
Oct 11, 2023

Conversation

rzhao271
Copy link
Contributor

@rzhao271 rzhao271 commented Oct 9, 2023 •
edited

Part of an internal work item.

@rzhao271 rzhao271 self-assigned this Oct 9, 2023
@rzhao271 rzhao271 enabled auto-merge (squash) October 9, 2023 22:42
@rzhao271 rzhao271 added this to the October 2023 milestone Oct 9, 2023
@rzhao271 rzhao271 requested review from deepak1556, joaomoreno, lszomoru and connor4312 and removed request for connor4312 October 9, 2023 22:42
@rzhao271 rzhao271 disabled auto-merge October 9, 2023 22:44
@rzhao271
Copy link
Contributor Author

rzhao271 commented Oct 9, 2023

Disabling auto-merge to get more feedback before merging in the change.
I accidentally added Connor to the review because I thought I changed up some CLI files, but it appears I haven't.

@rzhao271
Copy link
Contributor Author

rzhao271 commented Oct 9, 2023

Made changes to some CLI files.

deepak1556
deepak1556 reviewed Oct 10, 2023
View reviewed changes
Copy link
Contributor

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Is the name edits to specify (OSS), (Windows) etc purely for debugging purpose or is it more of a styleguide thing to distinguish similar displayName that should be followed from here onwards ?

@rzhao271
Copy link
Contributor Author

It's purely for debugging purposes and because I was confused while seeing the same step seemingly duplicated multiple times

@rzhao271
Copy link
Contributor Author

I'll merge the changes in tomorrow if there are no objections

@rzhao271 rzhao271 merged commit 18a25cd into main Oct 11, 2023
6 checks passed
@rzhao271 rzhao271 deleted the rzhao271/clarify-pipelines branch October 11, 2023 16:05
Alex0007 pushed a commit to Alex0007/vscode that referenced this pull request Oct 26, 2023
@rzhao271 @Alex0007
Clarify pipeline actions (microsoft#195197)
3c2ec4d
@github-actions github-actions bot locked and limited conversation to collaborators Nov 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

@connor4312 connor4312 connor4312 approved these changes

@lszomoru lszomoru lszomoru approved these changes

@joaomoreno joaomoreno Awaiting requested review from joaomoreno

Assignees

@rzhao271 rzhao271

Labels
None yet
Projects
None yet
Milestone
October 2023
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rzhao271 @deepak1556 @connor4312 @lszomoru