Various continue on comments fixes #195260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix duplicate continue-on comments
aeschli
approved these changes
Oct 10, 2023
| this.commentService.createCommentThreadTemplate(thread.owner, thread.uri, Range.lift(thread.range)); | ||
| }); | ||
| for (const thread of info.pendingCommentThreads ?? []) { | ||
| this.resumePendingComment(this.editor!.getModel()!.uri, thread); |
There was a problem hiding this comment.
Intentionally not awaited?
There was a problem hiding this comment.
For this call, it doesn't matter either way and the enclosing method is not already async.
TylerLeonhardt
approved these changes
Oct 10, 2023
Alex0007
pushed a commit
to Alex0007/vscode
that referenced
this pull request
Oct 26, 2023
* Various continue on comments fixes Part of microsoft#194288 * Fix continue-on reply being restored before root comment Fix duplicate continue-on comments * Include monaco.d.ts changes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix continue-on reply being restored before root comment
Fix duplicate continue-on comments
Fix comment replies being restored as new threads
Part of #194288