adjust commandStartX after polling succeeds
#195482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meganrogge
commented
Oct 12, 2023
src/vs/platform/terminal/common/capabilities/commandDetectionCapability.ts
Outdated
Show resolved
Hide resolved
Tyriar
requested changes
Oct 12, 2023
src/vs/platform/terminal/common/capabilities/commandDetectionCapability.ts
Outdated
Show resolved
Hide resolved
Tyriar
reviewed
Oct 12, 2023
src/vs/platform/terminal/common/capabilities/commandDetectionCapability.ts
Outdated
Show resolved
Hide resolved
Tyriar
previously requested changes
Oct 12, 2023
src/vs/platform/terminal/common/capabilities/commandDetectionCapability.ts
Outdated
Show resolved
Hide resolved
meganrogge
commented
Oct 12, 2023
src/vs/workbench/services/extensions/common/extensionsApiProposals.ts
Outdated
Show resolved
Hide resolved
meganrogge
force-pushed
the
merogge/command-start-x
branch
from
a9fe606
to
428dd5d
Compare
Tyriar
previously approved these changes
Oct 12, 2023
rzhao271
approved these changes
Oct 12, 2023
rzhao271
approved these changes
Oct 12, 2023
auto-merge was automatically disabled
October 13, 2023 00:00
Pull request was closed
meganrogge
added a commit
that referenced
this pull request
Oct 13, 2023
adjust `commandStartX` after polling succeeds
Alex0007
pushed a commit
to Alex0007/vscode
that referenced
this pull request
Oct 26, 2023
…art-x adjust `commandStartX` after polling succeeds
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #195374