add clear audio cue, accessible notification service #195517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meganrogge
commented
Oct 12, 2023
meganrogge
changed the title
meganrogge
commented
Oct 12, 2023
src/vs/platform/accessibility/test/common/testAccessibilityService.ts
Outdated
Show resolved
Hide resolved
meganrogge
changed the title
meganrogge
commented
Oct 12, 2023
meganrogge
force-pushed
the
merogge/clear-cue
branch
from
87d4190
to
a82ba5f
Compare
joyceerhl
approved these changes
Oct 13, 2023
Alex0007
pushed a commit
to Alex0007/vscode
that referenced
this pull request
Oct 26, 2023
add clear audio cue, accessible notification service
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #194939
Also adds a new service for notifying users in an accessible way in advance of #195282