Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix variables in chatAgents2 API requests, add tests #195529

Merged
merged 5 commits into from
Oct 13, 2023
Merged

Fix variables in chatAgents2 API requests, add tests #195529

merged 5 commits into from
Oct 13, 2023

Conversation

roblourens
Copy link
Member

@roblourens roblourens commented Oct 13, 2023 •
edited

  • Fix the variable values bag for chatAgents2 requests
  • Add integration tests for the provider and chat agent
  • Enable some flags by default on Insiders

@roblourens roblourens enabled auto-merge (squash) October 13, 2023 01:45
@VSCodeTriageBot VSCodeTriageBot added this to the October 2023 milestone Oct 13, 2023
@roblourens roblourens changed the title Fix variables in chatAgents2 API requests Fix variables in chatAgents2 API requests, add tests Oct 13, 2023
connor4312
connor4312 previously approved these changes Oct 13, 2023
View reviewed changes
@roblourens roblourens merged commit 6c02f61 into main Oct 13, 2023
6 checks passed
@roblourens roblourens deleted the roblou/frail-felidae branch October 13, 2023 04:27
meganrogge pushed a commit that referenced this pull request Oct 13, 2023
@roblourens @meganrogge
Fix variables in chatAgents2 API requests, add tests (#195529)
5d6a923 
* Fix variables in chatAgents2 API requests

* Enable file references and the 'used references' section by default in Insiders

* Add integration tests for chat

* Fix equality

* fix test
Alex0007 pushed a commit to Alex0007/vscode that referenced this pull request Oct 26, 2023
@roblourens @Alex0007
Fix variables in chatAgents2 API requests, add tests (microsoft#195529)
bc35f33 
* Fix variables in chatAgents2 API requests

* Enable file references and the 'used references' section by default in Insiders

* Add integration tests for chat

* Fix equality

* fix test
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bpasero bpasero bpasero approved these changes

@connor4312 connor4312 connor4312 left review comments

Assignees

@roblourens roblourens

Labels
None yet
Projects
None yet
Milestone
October 2023
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@roblourens @bpasero @connor4312 @VSCodeTriageBot