Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rerender chat pane when provider is added #195845

Merged
merged 1 commit into from
Oct 17, 2023
Merged

fix: rerender chat pane when provider is added #195845

merged 1 commit into from
Oct 17, 2023

Conversation

joyceerhl
Copy link
Contributor

@joyceerhl joyceerhl self-assigned this Oct 17, 2023
@joyceerhl joyceerhl enabled auto-merge (squash) October 17, 2023 23:32
@VSCodeTriageBot VSCodeTriageBot added this to the October 2023 milestone Oct 17, 2023
@joyceerhl joyceerhl merged commit e5b7340 into main Oct 17, 2023
7 checks passed
@joyceerhl joyceerhl deleted the dev/joyceerhl/additional-primate branch October 17, 2023 23:48
@roblourens
Copy link
Member

If I start a chat, reload the window, this fires and clears out the persisted model

@roblourens
Copy link
Member

Maybe do this only when there is no model already

roblourens added a commit that referenced this pull request Oct 18, 2023
@roblourens
Revert "fix: rerender chat pane when provider is added (#195845)"
3aaea56 
This reverts commit e5b7340.
@roblourens roblourens mentioned this pull request Oct 18, 2023
Merged
@roblourens
Copy link
Member

Reverting for now

@smoothzebra
Copy link

smoothzebra commented Oct 18, 2023 via email

roblourens added a commit that referenced this pull request Oct 18, 2023
@roblourens
Revert "fix: rerender chat pane when provider is added (#195845)" (#1…
7ff40aa 
…95860)

This reverts commit e5b7340.
Alex0007 pushed a commit to Alex0007/vscode that referenced this pull request Oct 26, 2023
@joyceerhl @Alex0007
fix: rerender chat pane when provider is added (microsoft#195845)
a962b44
Alex0007 pushed a commit to Alex0007/vscode that referenced this pull request Oct 26, 2023
@roblourens @Alex0007
Revert "fix: rerender chat pane when provider is added (microsoft#195845
8199243 
)" (microsoft#195860)

This reverts commit e5b7340.
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rzhao271 rzhao271 rzhao271 approved these changes

Assignees

@joyceerhl joyceerhl

Labels
None yet
Projects
None yet
Milestone
October 2023
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@joyceerhl @roblourens @smoothzebra @rzhao271 @VSCodeTriageBot