Fixes Aria Label Showing [Object object]

[amaust]

closes #195661
Switches aria-label titles to tooltip titles for certain instances where options.title is a markdown string.

[meganrogge]

Thanks so much for looking into this @amaust. Have you made sure this works well for all of these areas?

[meganrogge]

@lramos15 this changes some code that you added

[amaust]

@meganrogge I ran the unit tests but I did not think about double checking those. My apologies, I'll look into it ASAP.

[lramos15]

This actually isn't quite the same and breaks some of the cases which this was intended to fix.

For example if you modify a file and it's under source control the aria label will read out

~/path/test.md • Modified

but the label will just be test.md. Hiding some of that information from screen reader users. I will leave it up to @meganrogge to decide what should be done for terminal. My suggestion would be that maybe typeof options.title === 'string' ? options.title : label;

[amaust]

Sorry about that @lramos15, I was thinking about trying what you suggested as soon as I began looking at the other cases. Lemme know how you wanna proceed.

[amaust]

@lramos15 I did go ahead and made the fix you suggested. I also went and verified the case you specified and it worked as expected. Let me know if any other changes need to be made!