fix: use persisted chat session #195959
Merged
fix: use persisted chat session #195959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also don't record init failure on session clear
roblourens
approved these changes
Oct 19, 2023
| sessionId = this.viewState.sessionId; | ||
| } | ||
|
|
||
| const sessionId = this.getSessionId(); | ||
| // Render the welcome view if this session gets disposed at any point, | ||
| // including if the provider registration fails | ||
| const disposeListener = sessionId ? this._register(this.chatService.onDidDisposeSession((e) => { |
There was a problem hiding this comment.
Maybe this listener could be set up once in the constructor? I think this pattern is fine though. Thanks!
Alex0007
pushed a commit
to Alex0007/vscode
that referenced
this pull request
Oct 26, 2023
Also don't record init failure on session clear
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also don't record init failure on session clear
cc @roblourens