New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for hangul alt chars #196204
Support for hangul alt chars #196204
Conversation
@TylerLeonhardt what do you think about this new "alternate characters" concept? This could be adopted by other languages as needed. Here's what I plan on doing on the PR still but don't have time this iteration: (moved to top) |
I like the approach and think this is a good list of tasks. I wonder if there are other places where we can use this (settings editor, keybindings editor, etc) |
Where ever this shared filtering code is used they'll get it for free, but I'm also planning on making it its own independent module if something else wants to integrate 👍 |
@TylerLeonhardt this is pretty solid now, it doesn't work in go to file through which is one of the big use cases. I'm not sure if I can easily add it to go to file? |
Note that this does not work in contiguous searches, so it must match from the start of the word. It's a hard optimization problem to get it to work for contiguous string checking too, at least without changing how that works to get off |
Part of #196203
TODO
altChars.ts
?) as this concept could be used elsewhere