Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Maximize Editor Group #196289

Closed
2 tasks done
benibenj opened this issue Oct 23, 2023 · 2 comments
Closed
2 tasks done

Test: Maximize Editor Group #196289

benibenj opened this issue Oct 23, 2023 · 2 comments

Comments

@benibenj
Copy link
Contributor

benibenj commented Oct 23, 2023

Refs: #16927

Complexity: 4

Create Issue


We newly allow users to fully maximize an editor group when multiple editor groups are present. This will make the editor group fill the entire editor part and hide all other editor groups. When a editor group is maximized, an editor action icon is rendered in the toggled state on the tab bar. Pressing this action/button allows the user to return out of the maximized state.

The following ways can be used to maximize a group:

  • Command Palette: Maximize Group (If at least two groups are available)
  • Editor Title Menu: Maximize Group (If at least two groups are available)
  • Double Click Tab: Requires workbench.editor.doubleClickTabToToggleEditorGroupSizes: 'maximize'

The following ways can be used to maximize a group:

  • Command Palette: Unmaximize Group
  • Editor Title Menu: Unmaximize Group
  • Double Click Tab: Requires workbench.editor.doubleClickTabToToggleEditorGroupSizes: 'maximize'
  • Toggled unmaximize editor action in the tool bar
  • Changes to the editor grid will result in unmaximizing the editor group (adding/removing an editor group, opening a different editor group, closing the maximized editor group)
  • Changing the layout of the editor group with commands in the command palette:
    • Grid Editor Layout (2x2)
    • Reset Editor Group Sizes
    • ...

When unmaximizing we restore the layout/sizes of the editor groups as they were before maximizing.
The maximized view persists across window reloads, however, unmaximizing the maximized view after reloading the window might not restore the correct sizes.

Testing:
Try different combinations of methods to maximize/unmaximizing editor groups.
Use different amount of editor groups in different layouts
Make sure the view is still maximized after reloading the window

Recording 2023-10-23 at 17 23 26

@VSCodeTriageBot VSCodeTriageBot added this to the October 2023 milestone Oct 23, 2023
@benibenj benibenj changed the title Maximize Editor Group Test: Maximize Editor Group Oct 23, 2023
@alexr00 alexr00 removed their assignment Oct 24, 2023
@alexr00
Copy link
Member

alexr00 commented Oct 24, 2023

👏

@anthonykim1
Copy link
Contributor

I love this feature!

@anthonykim1 anthonykim1 removed their assignment Oct 24, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants