Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move debug adapter protocol to separate repository #19636

Closed
weinand opened this issue Jan 31, 2017 · 7 comments
Closed

move debug adapter protocol to separate repository #19636

weinand opened this issue Jan 31, 2017 · 7 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality verified Verification succeeded

Comments

@weinand
Copy link
Contributor

weinand commented Jan 31, 2017

move debug adapter protocol schema and accompanying documentation (Readme.md) to a separate repository.

@weinand weinand self-assigned this Jan 31, 2017
@weinand weinand added debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality labels Jan 31, 2017
@weinand weinand added this to the February 2017 milestone Jan 31, 2017
@weinand weinand modified the milestones: March 2017, February 2017 Feb 16, 2017
@weinand weinand modified the milestones: Backlog, March 2017 Mar 28, 2017
@weinand weinand changed the title move debug adapter protocol move debug adapter protocol to separate repository Jul 13, 2017
@svenefftinge
Copy link

Any progress here?
Can we somehow help get this going?

@smarter
Copy link

smarter commented Oct 30, 2017

It'd be great to see some work towards standardizing the vscode debug protocol following the success of the LSP (see also https://github.com/Microsoft/vscode-debugadapter-node/issues/59), and this would be a good first step. Getting other IDEs to implement the vscode debug protocol would be especially useful now that the Java Debug Server has been released.

@weinand
Copy link
Contributor Author

weinand commented Oct 30, 2017

Is the fact that the debug protocol lives in https://github.com/Microsoft/vscode-debugadapter-node blocking anyone from adopting it?

@gorkem
Copy link

gorkem commented Oct 30, 2017

@weinand I think debug protocol feels more like an internal vscode thing than LSP. It starts with the name of the repositories, LSP lives on language-server-protocol vs the vscode-debugadapter-node which is prefixed vscode. README file for the debug things repo also does help either. It only talks about VS Code and has no information around contribution. I love the fact that there is a json schema for debug protocol but there is no information on the repository that schema is the source of truth for the protocol. At the moment, it is even a bigger leap of faith (yeah, I think LSP needs open governance) for Eclipse Che, Atom or any other editor to adopt debug protocol. And because it feels like an internal implementation so far Red Hat could not really consider it for adoption.

@CestDiego
Copy link

This feature has great potential. I believe that with more documentation and some in-house guides on how to create adapters for other editors (starting with Atom maybe?) this would be a step in the right direction.

@weinand
Copy link
Contributor Author

weinand commented Jan 8, 2018

@CestDiego The idea behind debug adapters is to be independent from a debugger frontend so that they can be reused across different IDEs. So "creating adapters" for Atom doesn't make any sense. The better approach would be to host debug adapters in Atom.

@weinand
Copy link
Contributor Author

weinand commented Sep 11, 2018

The DAP now lives here: https://microsoft.github.io/debug-adapter-protocol/

@weinand weinand closed this as completed Sep 11, 2018
@weinand weinand modified the milestones: Backlog, September 2018 Sep 11, 2018
@weinand weinand added the verified Verification succeeded label Sep 21, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants