Fix textarea sync edge cases #197025
Merged
Fix textarea sync edge cases #197025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- PowerShell is now handled with a specific regex which has an optional space at the end, if matched a space will be added to the end. This is needed because conpty may not 'render' the final space in the prompt. - Return true in _cursorOnNextLine check if there is a single command as this means it's the first command, so any match should be correct. - Increase polling to 1000ms (50x20ms) as it was being hit on my machine. Fixes #196758
meganrogge
reviewed
Oct 30, 2023
| @@ -442,8 +444,26 @@ export class CommandDetectionCapability extends Disposable implements ICommandDe | |||
| if (!line) { | |||
| return; | |||
| } | |||
| // TODO: fine tune prompt regex to accomodate for unique configurtions. | |||
| return line.translateToString(true)?.match(/^(?<prompt>(\(.+\)\s)?(?:PS.+>\s)|(?:[A-Z]:\\.*>))/)?.groups?.prompt; | |||
| // TODO: fine tune prompt regex to accomodate for unique configurations. | |||
There was a problem hiding this comment.
nit: could move this down to where it's relevant.
meganrogge
approved these changes
Oct 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #196758