Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch back to node as default for moduleResolution #197031

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

mjbvz
Copy link
Contributor

@mjbvz mjbvz commented Oct 30, 2023

For #196554

Looks like bundler breaks require() intellisense

@andrewbranch Can you take a look. For our upcoming release I'm just going to revert the config change but maybe there's a better way to fix this

Fixes microsoft#196554

Looks like bundler breaks `require()` intellisense
@mjbvz mjbvz self-assigned this Oct 30, 2023
@mjbvz mjbvz added this to the November 2023 milestone Oct 30, 2023
@mjbvz mjbvz enabled auto-merge (squash) October 30, 2023 22:41
Copy link
Member

@andrewbranch andrewbranch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot about this. We asked for user feedback and heard that when using a bundler, resorting to require is rare enough that this was fine. But it does make it a bad catch-all mode, unfortunately 😕

@mjbvz mjbvz merged commit 0279c52 into microsoft:main Oct 30, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants