Support debug tool bar float on custom title bar #197070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like these changes overall 👏 +1 for shortening the debug toolbar all the time fyi @connor4312 |
connor4312
reviewed
Oct 31, 2023
|
nice! One comment |
|
@connor4312 Addressed the feedback |
connor4312
approved these changes
Oct 31, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: My setup contains custom titlebar without command center and tabs hidden and I want to have debug tool bar on the custom title bar.
Floating debug tool bar is allowed to be placed anywhere in the two rows below the title bar. I enabled this to also be placed on the custom title bar. Please check the following gif.
Also note that, I have shortened the tool bar when tabs and command center are hidden to match the titlebar height. In general I liked the shortened version. So, how about shortening the debug tool bar always?
CC @isidorn