Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix localization issues in terminal find and history hint #197073

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Fix localization issues in terminal find and history hint #197073

merged 2 commits into from
Oct 31, 2023

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Oct 31, 2023 •
edited

Fixes #197071

After (same as before for English):

image
image

image
image

The result of this change should be:

  • or will be localized
  • The spaces can be removed from the history hint suffix if it makes sense in the language
  • History hints in simple find width will no longer double up
  • The arrow symbol will not be surfaced to translators
  • Better instructions to translators

cc @gjsjohnmurray

@Tyriar Tyriar added this to the November 2023 milestone Oct 31, 2023
@Tyriar Tyriar self-assigned this Oct 31, 2023
@Tyriar Tyriar enabled auto-merge October 31, 2023 14:26
@Tyriar Tyriar merged commit 14849e4 into main Oct 31, 2023
7 checks passed
@Tyriar Tyriar deleted the tyriar/197071 branch October 31, 2023 15:21
@github-actions github-actions bot locked and limited conversation to collaborators Dec 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TylerLeonhardt TylerLeonhardt TylerLeonhardt approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
November 2023
Development

Successfully merging this pull request may close these issues.

Terminal find localized string has problems
2 participants
@Tyriar @TylerLeonhardt