fix: restore Dark Modern preformat foreground #197124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The real fix is to update index.html to use the new preformat-background colors, but that's a larger change than we should take for endgame, so this commit just reverts to the previous colors we had for the release
joyceerhl
force-pushed
the
dev/joyceerhl/varied-panda
branch
from
b7831cd
to
1ccbfc5
Compare
joyceerhl
commented
Nov 1, 2023
| @@ -113,7 +113,7 @@ | |||
| "textCodeBlock.background": "#2B2B2B", | |||
| "textLink.activeForeground": "#4daafc", | |||
| "textLink.foreground": "#4daafc", | |||
| "textPreformat.foreground": "#D0D0D0", | |||
| "textPreformat.foreground": "#D7BA7D", | |||
There was a problem hiding this comment.
This is required for code blocks in Markdown previews in Dark Modern to render in a distinct color
joyceerhl
commented
Nov 1, 2023
| @@ -131,7 +131,7 @@ | |||
| "textCodeBlock.background": "#F8F8F8", | |||
| "textLink.activeForeground": "#005FB8", | |||
| "textLink.foreground": "#005FB8", | |||
| "textPreformat.foreground": "#3B3B3B", | |||
| "textPreformat.foreground": "#A31515", | |||
There was a problem hiding this comment.
This is required for code blocks in Markdown previews in Light Modern to render in a distinct color
joyceerhl
commented
Nov 1, 2023
| @@ -227,7 +227,7 @@ export const selectionBackground = registerColor('selection.background', { light | |||
| export const textSeparatorForeground = registerColor('textSeparator.foreground', { light: '#0000002e', dark: '#ffffff2e', hcDark: Color.black, hcLight: '#292929' }, nls.localize('textSeparatorForeground', "Color for text separators.")); | |||
| export const textLinkForeground = registerColor('textLink.foreground', { light: '#006AB1', dark: '#3794FF', hcDark: '#3794FF', hcLight: '#0F4A85' }, nls.localize('textLinkForeground', "Foreground color for links in text.")); | |||
| export const textLinkActiveForeground = registerColor('textLink.activeForeground', { light: '#006AB1', dark: '#3794FF', hcDark: '#3794FF', hcLight: '#0F4A85' }, nls.localize('textLinkActiveForeground', "Foreground color for links in text when clicked on and on mouse hover.")); | |||
| export const textPreformatForeground = registerColor('textPreformat.foreground', { light: '#A31515', dark: '#D7BA7D', hcDark: '#000000', hcLight: '#FFFFFF' }, nls.localize('textPreformatForeground', "Foreground color for preformatted text segments.")); | |||
| export const textPreformatForeground = registerColor('textPreformat.foreground', { light: '#A31515', dark: '#D7BA7D', hcDark: '#D7BA7D', hcLight: '#292929' }, nls.localize('textPreformatForeground', "Foreground color for preformatted text segments.")); | |||
There was a problem hiding this comment.
This is required for code blocks in Markdown previews in HC themes to be visible at all
joyceerhl
commented
Nov 1, 2023
| @@ -244,7 +244,6 @@ | |||
| font-family: var(--monaco-monospace-font); | |||
| font-size: 12px; | |||
| color: var(--vscode-textPreformat-foreground); | |||
| background-color: var(--vscode-textPreformat-background); | |||
There was a problem hiding this comment.
This is required to ensure that code blocks are visible in chat after updating vscode-textPreformat-foreground
joyceerhl
commented
Nov 1, 2023
| @@ -533,7 +533,6 @@ | |||
| font-family: var(--monaco-monospace-font); | |||
| font-size: 11px; | |||
| color: var(--vscode-textPreformat-foreground); | |||
| background-color: var(--vscode-textPreformat-background); | |||
There was a problem hiding this comment.
This is required to ensure that code blocks are visible in the settings UI after updating vscode-textPreformat-foreground
TokenPayId
approved these changes
Nov 1, 2023
bhavyaus
approved these changes
Nov 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.