fix: set border for chat file trees #197170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roblourens
reviewed
Nov 1, 2023
| @@ -526,10 +525,10 @@ | |||
| gap: 6px; | |||
| } | |||
|
|
|||
| .interactive-response-progress-tree .monaco-list, | |||
There was a problem hiding this comment.
Does it matter whether these are one the monaco-list or the parent? Shouldn't this just match used-context-list exactly?
There was a problem hiding this comment.
I seem to recall that it was important to set it on the monaco-list, can't remember why though and it looks fine setting it on the parent element for now
karthiknadig
approved these changes
Nov 1, 2023
aeschli
approved these changes
Nov 1, 2023
daviddossett
reviewed
Nov 1, 2023
| .interactive-session .chat-used-context-list { | ||
| border: 1px solid var(--vscode-chat-requestBorder); | ||
| border-radius: 4px; | ||
| padding: 4px; |
There was a problem hiding this comment.
This padding was intentional fwiw. It did cause some side effects for lists that scrolled though which I do want to fix.
Without it, we get this:
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/microsoft/vscode-copilot/issues/2571