debug: improve performance of stepping #197397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we did not show a next-stepped state until the entire stackframe was retrieved, which led to the issue this fixes #185708. This queuing was done to prevent torn states in similar fast transitions. Rather than queuing, this PR uses a small 'scheduler' that uses a cancellation token to abort any running operations on a per-thread basis. I also noticed we didn't fully support `allThreadStopped`. I added support for that as well.
|
cc @roblourens |
joyceerhl
approved these changes
Nov 3, 2023
|
🔥 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we did not show a next-stepped state until the entire
stackframe was retrieved, which led to the issue this fixes #185708.
This queuing was done to prevent torn states in similar fast
transitions.
Rather than queuing, this PR uses a small 'scheduler' that uses a
cancellation token to abort any running operations on a per-thread basis.
I also noticed we didn't fully support
allThreadStopped. I addedsupport for that as well.