Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace deprecated octal escape sequences with hex #197518

Merged
merged 2 commits into from
Dec 20, 2023
Merged

chore: replace deprecated octal escape sequences with hex #197518

merged 2 commits into from
Dec 20, 2023
+5 −5

Conversation

MrJithil
Copy link
Contributor

@MrJithil MrJithil commented Nov 6, 2023

Fixes #197517

@ulugbekna ulugbekna removed their assignment Dec 4, 2023
@joaomoreno joaomoreno added the engineering VS Code - Build / issue tracking / etc. label Dec 20, 2023
@joaomoreno joaomoreno added this to the December / January 2024 milestone Dec 20, 2023
@joaomoreno joaomoreno enabled auto-merge (squash) December 20, 2023 15:16
@joaomoreno joaomoreno merged commit 01fc311 into microsoft:main Dec 20, 2023
6 checks passed
@microsoft microsoft locked and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joaomoreno joaomoreno joaomoreno approved these changes

@ulugbekna ulugbekna ulugbekna approved these changes

Assignees

@joaomoreno joaomoreno

Labels
engineering VS Code - Build / issue tracking / etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Octal literals and octal escape sequences are deprecated in build/npm/preinstall.js
4 participants
@MrJithil @joaomoreno @ulugbekna @VSCodeTriageBot