Adopt Better-Less grammar #197557
Adopt Better-Less grammar #197557
Conversation
|
@aeschli, this new grammar fixes a couple issues and will be maintained going forward. However, it does require a few updates to themes to keep most of the colors the same, which means that themes contributed by extensions may also require updates. Do you think these theme changes are to much? I intend to keep this grammar in insiders for 2 releases before releasing to stable. |
|
Looks good to me! |
|
@aeschli great, thanks for taking a look! |
|
@radium-v, just a heads up that this is going in! I'll keep it in VS Code insiders until ~February. |
| "variable.css", | ||
| "variable.scss", | ||
| "variable.other.less", | ||
| "source.css.less variable.other", |
There was a problem hiding this comment.
I believe we can now merge the 3 lines with:
| "variable.css", | |
| "variable.scss", | |
| "variable.other.less", | |
| "source.css.less variable.other", | |
| "variable.css", | |
| "variable.scss", | |
| "source.css.less variable.other", |
I ran the tests on that and there's a change in css coloring in that variable.parameter.url.css now also gets the variable color. IMO that's the correct thing to do.
There was a problem hiding this comment.
I created #197657 for that change
* Revert "merge theme rules for css/less/scss variables (microsoft#197657)" This reverts commit cc08867. * Revert "Adopt Better-Less grammar (microsoft#197557)" This reverts commit ce40e7c.
Fixes #171239