Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cobey add missing js #197600

Merged
merged 5 commits into from
Nov 9, 2023
Merged

Cobey add missing js #197600

merged 5 commits into from
Nov 9, 2023

Conversation

cobey
Copy link
Contributor

@cobey cobey commented Nov 7, 2023

Adding @azure/openai

@mjbvz mjbvz assigned isidorn and unassigned mjbvz Nov 7, 2023
@isidorn isidorn added this to the November 2023 milestone Nov 7, 2023
@isidorn
Copy link
Contributor

isidorn commented Nov 7, 2023

@cobey thanks for adding these - you were reading my mind since I also wanted to add it this week.
Can you please just resolve the conflicts and then we can merge this in? Thank you 🙏

@isidorn
Copy link
Contributor

isidorn commented Nov 8, 2023

@hediet looks like monaco editor tests fail and this is unrelated to these changes.
https://github.com/microsoft/vscode/actions/runs/6802229024/job/18495185205?pr=197600
Do you have suggestions on how to proceed? Thank you

@isidorn isidorn merged commit 60aa195 into microsoft:main Nov 9, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants