Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move onCommandExecuted so it fires after command executed marker has been assigned #197666

Merged
merged 1 commit into from
Nov 7, 2023
Merged

move onCommandExecuted so it fires after command executed marker has been assigned #197666

merged 1 commit into from
Nov 7, 2023

Conversation

meganrogge
Copy link
Contributor

@jooyoungseo showed this still not working for him.

I was firing onCommandExecuted within a condition that shouldn't have to be met.

Now, when there's no commandExecutedMarker and commandFinished is about to occur, it's safe to fire onCommandExecuted.

@meganrogge
fire command executed once commandExecutedMarker has been assigned an…
084ddc2 
…d the marker does not exist before command finished
@meganrogge meganrogge self-assigned this Nov 7, 2023
@meganrogge meganrogge added this to the November 2023 milestone Nov 7, 2023
@meganrogge meganrogge merged commit 7613fdc into main Nov 7, 2023
7 checks passed
@meganrogge meganrogge deleted the merogge/command-executed branch November 7, 2023 21:13
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

@meganrogge meganrogge

Labels
None yet
Projects
None yet
Milestone
November 2023
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@meganrogge @Tyriar